Repository navigation
Release/v1.11.0 - #227
Merged
Merged
Release/v1.11.0#227
Conversation
…y unique in the general ledger
Match invoice bundle components to their own parent line (#224)
fivetran-avinash
approved these changes
Oct 16, 2026
fivetran-avinash
left a comment
fivetran-avinash
left a comment
Contributor
There was a problem hiding this comment.
@fivetran-savage Approved with a few suggestions/updates.
| | Data Model(s) | Change type | Old | New | Notes | | ||
| | ------------- | ----------- | --- | --- | ----- | | ||
| | `int_quickbooks__invoice_double_entry`, `quickbooks__general_ledger` **Possible breaking change** | Changed field | Bundle component `index` / `transaction_index` is the component's position within its bundle | `20000 + parent line index * 1000 + component index` | Prevents duplicate `unique_id` values. | | ||
| | `int_quickbooks__invoice_double_entry`, `quickbooks__general_ledger` | Changed model | Bundle components join to every line on the invoice | Bundle components join only to their own parent line | Fixes duplicated component amounts and dropped lines on invoices that mix bundles and other lines ([#224](https://github.com/fivetran/dbt_quickbooks/issues/224)). | |
Contributor
There was a problem hiding this comment.
Suggest adding to the Notes section: “Components whose invoice_line_index doesn’t match an invoice line are no longer posted.”
This is a behavior change that anyone with orphaned components would notice. Our 40113 seed shows it, with $10,252.95 dropping out.
|
|
||
| | Data Model(s) | Change type | Old | New | Notes | | ||
| | ------------- | ----------- | --- | --- | ----- | | ||
| | `int_quickbooks__invoice_double_entry`, `quickbooks__general_ledger` **Possible breaking change** | Changed field | Bundle component `index` / `transaction_index` is the component's position within its bundle | `20000 + parent line index * 1000 + component index` | Prevents duplicate `unique_id` values. | |
Contributor
There was a problem hiding this comment.
Also worth noting that bundle component unique_id values change. Consider an additional statement like: “Downstream models you keep on unique_id see these rows as new.”
|
|
||
| | Data Model(s) | Change type | Old | New | Notes | | ||
| | ------------- | ----------- | --- | --- | ----- | | ||
| | `int_quickbooks__invoice_double_entry`, `quickbooks__general_ledger` **Possible breaking change** | Changed field | Bundle component `index` / `transaction_index` is the component's position within its bundle | `20000 + parent line index * 1000 + component index` | Prevents duplicate `unique_id` values. | |
Contributor
There was a problem hiding this comment.
Suggested updates to this entry (decisionlog link + moving end model to top)
Suggested change
| | `int_quickbooks__invoice_double_entry`, `quickbooks__general_ledger` **Possible breaking change** | Changed field | Bundle component `index` / `transaction_index` is the component's position within its bundle | `20000 + parent line index * 1000 + component index` | Prevents duplicate `unique_id` values. | | |
| | `quickbooks__general_ledger`<br>`int_quickbooks__invoice_double_entry` | Changed field | Bundle component `index` / `transaction_index` is the component's position within its bundle | `20000 + parent line index * 1000 + component index` | **Possible breaking change** Prevents duplicate `unique_id` values. See the [DECISIONLOG](https://github.com/fivetran/dbt_quickbooks/blob/main/DECISIONLOG.md#invoice-bundle-component-index-offset) for details. | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Overview
Package version introduced in this PR:
This PR addresses the following Issue/Feature(s):
Summary of changes:
int_quickbooks__invoice_double_entrywhere bundle components joined to every line on an invoice and repeated once per income account, duplicating amounts inquickbooks__general_ledger.int_quickbooks__invoice_double_entrywhere bundle components could share an index with regular lines or with components from another bundle, which created duplicateunique_idvalues.Submission Checklist
Changelog