Repository navigation
Fix four column descriptions copied from other columns - #229
Open
aremondtiedrez wants to merge 1 commit into
Open
aremondtiedrez wants to merge 1 commit into
aremondtiedrez wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #228
Please provide your name and company
Antoine Remond-Tiedrez
Describe what this PR changes and how it addresses the linked issue or feature request.
Fixes the four column descriptions listed in the linked issue, which were word-for-word copies of another column's description and so named the wrong record. Each is corrected in both
models/staging/src_quickbooks.ymlandmodels/staging/stg_quickbooks.yml, eight lines in total:invoice.transaction_datevendor.balancepurchase_order_line.amountpurchase_order_line.descriptionThe staging file words two of these slightly differently ("Date which the deposit transaction occurred." and "Monetary amount of the purchase.") and those are corrected the same way. The columns the text was copied from (
deposit.transaction_date,customer.balance,purchase_line.amount,purchase_line.description) are unchanged.How did you validate the changes introduced within this PR, and what warehouse did you use for testing?
Documentation-only change, so no warehouse run. I checked that the diff touches only the eight
description:lines (2 files, 8 insertions, 8 deletions) and that both YAML files still parse.