Skip to content

Fix four column descriptions copied from other columns - #229

Open
aremondtiedrez wants to merge 1 commit into
fivetran:mainfrom
aremondtiedrez:fix/copied-column-descriptions
Open

aremondtiedrez wants to merge 1 commit into
fivetran:mainfrom
aremondtiedrez:fix/copied-column-descriptions

Conversation

@aremondtiedrez

@aremondtiedrez aremondtiedrez commented Oct 20, 2026 •

Copy link
Copy Markdown

Resolves #228

Please provide your name and company

Antoine Remond-Tiedrez

Describe what this PR changes and how it addresses the linked issue or feature request.

Fixes the four column descriptions listed in the linked issue, which were word-for-word copies of another column's description and so named the wrong record. Each is corrected in both models/staging/src_quickbooks.yml and models/staging/stg_quickbooks.yml, eight lines in total:

Column Before After
invoice.transaction_date "Date of the day which the deposit transaction occurred." "Date of the day which the invoice transaction occurred."
vendor.balance "Specifies the open balance amount or the amount unpaid by the customer." "Specifies the open balance amount or the amount still owed to the vendor."
purchase_order_line.amount "{{ doc('amount') }} the purchase." "{{ doc('amount') }} the purchase order line."
purchase_order_line.description "User defined description of the purchase line." "User defined description of the purchase order line."

The staging file words two of these slightly differently ("Date which the deposit transaction occurred." and "Monetary amount of the purchase.") and those are corrected the same way. The columns the text was copied from (deposit.transaction_date, customer.balance, purchase_line.amount, purchase_line.description) are unchanged.

How did you validate the changes introduced within this PR, and what warehouse did you use for testing?

Documentation-only change, so no warehouse run. I checked that the diff touches only the eight description: lines (2 files, 8 insertions, 8 deletions) and that both YAML files still parse.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Four column descriptions copied from other columns in src_quickbooks.yml and stg_quickbooks.yml

1 participant