Repository navigation
Partition retained earnings window functions by source_relation - #233
Open
porkedchop wants to merge 1 commit into
Open
porkedchop wants to merge 1 commit into
porkedchop wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #232
Please provide your name and company
Bishop Kammeraad
Describe what this PR changes and how it addresses the linked issue or feature request.
In
int_quickbooks__retained_earnings, movespartition_by_source_relationfrom theorder byto the start of the four window functions, withhas_other_partitions='no'. When unioning connections the windows now renderpartition by source_relation, so the running sum andlagstay within each connection. With a single connection the macro renders nothing and the output is unchanged.How did you validate the changes introduced within this PR, and what warehouse did you use for testing?
DuckDB with two copies of the integration test data unioned through
quickbooks_union_schemas. The Net Income Adjustmentperiod_ending_balancefor 2026-02-01 goes from 122920 to 61460 for each connection, matching the single connection result. For 2020-01-01,qb2goes from beginning -600 / ending -1200 to beginning 0 / ending -600.quickbooks__general_ledger_by_periodhas 7396 rows before and after. The single connection integration test output is unchanged.dbt buildpasses in both setups.This edits the same
period_beginning_converted_balanceline as #231, so whichever merges second needs a one-line rebase.