Harden Markdown builds and styling - #95
Open
moshloop wants to merge 27 commits into
Open
Conversation
Map diagram endpoints explicitly and wait for layout stabilization so arrows render against final coordinates and remain correctly positioned in print output
Ensure @LiVe templates render through the browser path automatically and raw MDX is transformed before React in dev mode. Prevents incorrect static rendering and React parse failures.
Add doctor coverage for the shared Facet module store and Tailwind package/plugin layout. This surfaces missing or incompatible dependencies and supports repair through `facet doctor --skip-modules --fix`.
Add immutable shared module stores, persistent build-key digests, Tailwind v3/v4 CSS handling, filtered Markdown transforms, and low-priority subprocess execution to reduce repeated install, scan, and render costs. Add skip-modules support and improve cache invalidation, diagnostics, and loader cleanup. BREAKING CHANGE: Replace the positional computeTemplateBuildKey API and remove FacetDirectory.needsInstall and isInstallBroken; callers must use the new options-based and module-preparation APIs.
Add Facet server rendering for HTML/PDF jobs while preserving local data loading and validation, with explicit failures instead of local fallback. Introduce version-pinned shared modules, CSS post-processing controls, render timing diagnostics, and expanded API coverage for live/PDF options. BREAKING CHANGE: Require Node.js >=20.19; shared-module server mode rejects request-specific dependencies and local-only render options.
Make browser-backed diagrams render consistently in HTML/PDF output and expand the playground with reusable datasheet, diagram, Markdown, and MDX examples. Keep shared playground links reproducible through URL-synced toolbar state and surface server timings in the log dialog.
Deprioritize shell, SSR, and PDF browser work to reduce contention with interactive workloads. Extend benchmark profiling across stdout and stderr, and support numeric logger verbosity levels.\n\nBREAKING CHANGE: PersistentLoaderRequest replaces the verbose option with verbosity
Build and install the CLI from a versioned npm package with symlinked development installs and linked-version reporting. Add shared module-cache warmup, bundled runtime assets, and repeatable Kubernetes lab deployment with optional ingress.\nBREAKING CHANGE: The npm CLI now requires Node.js >=20.19 instead of >=18.
Expand the kitchen-sink report to exercise GFM, raw HTML, GitHub alerts, collapsible details, footnotes, and Mermaid diagrams. Add the rendering dependencies and remote HTML/PDF CLI integration coverage.
Replace react-xarrows rendering with measured SVG geometry so arrows stay aligned as diagram layouts settle. Preserve anchors, paths, markers, labels, and animation while adding layout readiness and geometry regression coverage.
Add PNG output with configurable capture dimensions, selectors, viewports, and autocropping. Extend request validation, caching, streamed results, and playground previews for image renders.
Add PNG generation across the CLI, render API, and remote rendering path. Capture selected elements at natural size with viewport-aware scaling and optional painted-pixel autocropping. Bundle Sharp resolution for native module environments, document the new format, and cover local, API, remote, and cropping behavior with tests.
Centralize data-file loading with YAML support and clear validation errors. Select the appropriate JSON Schema draft while preserving renderer annotations without weakening actual constraints.
Bundle icon data and load template utilities so live and SSR renders preserve glyphs and diagram layout. Resolve the Vite root reliably and include sharp for SEA autocrop support. Add React 19 diagram coverage for finite arrow geometry.
Promote Document as the canonical wrapper across examples, playground templates, and Storybook while retaining DatasheetTemplate as a deprecated compatibility alias.
Add a validated font-size scale that keeps typography consistent across HTML, PNG, and PDF output. Align Tailwind utilities, inline styles, and packaged PostCSS processing with the shared point-based scale while preventing stale CSS caches and unsafe stylesheet interpolation. Add component test discovery and coverage for scaling, packaging, rendering, and cache invalidation.
Correct PDF output that ignored the declared typography scale, overflowed page boxes, and misreported debug annotations. Apply consistent font scaling and printable-height sizing across page surfaces, load the intended sans font, and prevent oversized page-number replacements from corrupting streams. Add focused coverage for rendered typography, scaling, pagination, annotations, and placeholder safety.
Synchronize public facet declarations with current component exports, including document, table, finding, formatting, heatmap, and typography APIs. Align StatCard tests with absolute deltas, slate neutral colors, and reduction semantics. BREAKING CHANGE: Remove legacy DatasheetTemplate PageConfig usage and the TerminalOutput command and SeverityStatCard downIsGood props from the declared API.
Unify TSX/MDX callouts with GitHub markdown alert tones, shared icons, annotation headers, and emphasis styling. Add focused component coverage and Storybook examples for the expanded API. BREAKING CHANGE: Remove the `info` and `success` variants; use `note` and `tip` instead
Add GitHub-style alert rendering and fail-closed Classified regions across Markdown/MDX, CLI, API, and cached builds. Redacted content is removed before compilation and remote-render policies are preserved. Document and test callout tones, policy parsing, CSS, and rendering behavior. BREAKING CHANGE: CalloutBox no longer accepts the info or success variants; use note, tip, important, warning, caution, or default
Read workspace-level pnpm overrides and explicitly disable frozen-lockfile mode during staging installs to keep generated consumer manifests and pnpm 11 resolution consistent. Remove obsolete dependency checksums from the chart test module.
Remove classified Markdown regions before compilation so redacted content is absent from generated bundles and output. Enforce explicit attribute policies and fail builds when classification rules are missing or malformed.
Restore correct block-level heading flow and style GitHub Markdown alert tones consistently with CalloutBox variants, including readable labels and icons.
|
Important Review skippedToo many files! This PR contains 160 files, which is 60 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (160)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Keep release, test, and runtime environments consistent with the repository’s pnpm requirement while covering packaged remark assets, layered CSS imports, and sharp diagnostics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why