Harden persistent download reliability - #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardens Launchly's first-stage download reliability without mixing in the larger authentication, APK trust, installer, or release-pipeline redesigns.
REPLACEwith@Upsertso managed-version edits do not cascade-delete download records0.3.0(versionCode 4)Verification
Executed locally against Android SDK 35:
Results:
0.3.0/ code4UPDATE ... WHERE id = ?adapter for existing managed-version rows rather than delete-and-insert replacementThe connected instrumented tests were compiled but not executed locally because no Android emulator/device is attached. The added Room regression test is included in the Android-test APK.
Review follow-ups handled
Two independent pre-commit reviews identified and this branch fixed:
ApkValidationExceptionand evade cache invalidationOut of scope
SHA-256 verification, clean generation-specific staging, official Minecraft signer pinning/lineage, durable downgrade transactions, Ackpine upgrade, and CI/release hardening remain separate follow-up PRs.