You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Refuse a person's approval of a set whose checks are still running #2670
Part of #2421 (F-RTE). Found in the review of #2668 (RTE-05 approvals). Not introduced by it: TransitionAsync(Approved) behaved this way before.
A person can approve a set while its checks are still running, and the set is then approved with no approval recorded and no count. The move from checks running to approved exists in the transition table for routing's auto-publish (RTE-01). AgentPermissions lets a person make every move, so IChangeSetDirectory.ApproveAsync or TransitionAsync(id, Approved) on a set in checks running approves it directly.
Nothing calls it today. The desk only offers Approve on a set awaiting review, and agents and engines are refused. A direct caller of the directory skips both the checks and the approval count, though.
Scope
Only the routing engine makes the move from checks running to approved, when routing lands (ADR-0012). A person's approval is refused unless the set awaits review, with the same refusal an approval of an approved set gets.
The table-driven transition tests take the person off that move.
Acceptance
A person's ApproveAsync or TransitionAsync(id, Approved) on a set in checks running is refused and stores nothing.
A set still reaches approved from awaiting review through its approvals, as before.
Activity
Require N approvals before a change set is approved (#2668)
pournasserian commentedon Oct 31, 2026
Closing as superseded: FluentCMS is restarting from scratch, see #2675. If this still matters to you, please open a new issue.