Skip to content

Fix the v2 build after the InitiatorKinds move - #2456

Merged
pournasserian merged 1 commit into
v2from
2454-fix-sign-in-tests-namespace
Oct 18, 2026
Merged

pournasserian merged 1 commit into
v2from
2454-fix-sign-in-tests-namespace

Conversation

@pournasserian

Copy link
Copy Markdown
Member

Closes #2454

What

SignInTests.cs imports FluentCMS.Core.Audit for InitiatorKinds instead of FluentCMS.Infrastructure.Audit, which it used for nothing else.

Why

#2449 moved InitiatorKinds to FluentCMS.Core.Audit, and #2450 was written against the old namespace. Each passed CI alone, but together they break the build on v2 and in every pull request into it, such as #2453. Build with warnings as errors and all unit and integration tests pass with the fix.

Checklist

  • Linked to an issue a maintainer has confirmed
  • Targets v2
  • Tests or docs updated where behaviour changed
  • No tool-generated co-author trailers or footers

@pournasserian pournasserian added this to the M1 Governance core milestone Oct 18, 2026
@pournasserian pournasserian added v2 FluentCMS v2 (v2 branch) type:bug Defect area:users Users and sign-in (USR) labels Oct 18, 2026
@pournasserian
pournasserian merged commit 34cb2ef into v2 Oct 18, 2026
2 checks passed
@pournasserian
pournasserian deleted the 2454-fix-sign-in-tests-namespace branch October 18, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:users Users and sign-in (USR) type:bug Defect v2 FluentCMS v2 (v2 branch)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix the v2 build: sign-in tests use the old InitiatorKinds namespace

1 participant