Repository navigation
Add bulk entry updates as a job and the get_job tool - #2644
Merged
Merged
Conversation
# Conflicts: # src/FluentCMS.Core/Builtin/Tools/ToolJson.cs # tests/FluentCMS.IntegrationTests/Mcp/McpAgents.cs # tests/FluentCMS.Tests/Tools/ToolProviderConformanceTests.cs
# Conflicts: # CONTRIBUTING.md # tests/FluentCMS.IntegrationTests/Mcp/ConnectedAgent.cs # tests/FluentCMS.IntegrationTests/Mcp/McpAgents.cs # tests/FluentCMS.Tests/Tools/McpCoverageTests.cs # tests/FluentCMS.Tests/Tools/ToolProviderConformanceTests.cs
3 of 4 tasks
… set, and name no unsaved set in the cap refusal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2539
What
Bulk operations (MCP-08) on the job queue. A bulk update returns a change set id and a job id at once, and the work continues in the background, with progress the agent can read.
bulk_update_entries: a list of{id, base_version, fields}for entries or entities, with a rationale and sources.IAgentPermissions.CheckNewChangeSetSizeAsync, since there is no set yet to name; its security event names the credential.bulk.entry_updates(BulkEntryUpdates, a job handler):submit_change_setrefuses an open set while a job other than its checks is queued or running on it, withchange_set_busy, so a reviewer never gets part of a bulk update.get_job: a job's type, state, subject, progress, attempts and last error. An agent sees only its own jobs.ToolArgumentsReader.RequiredArray.ToolJson.JobRecordsits beside the checks lane's shorterToolJson.Job.McpCoverageTests. CONTRIBUTING.md describes the tools.Why
MCP-08 asks that bulk tool calls return a change set id and continue in the background. The epic's case: "a bulk update of 180 entities returns a change set id immediately, and progress can be read until the set is ready for checks".
Choices worth a look:
submit_change_setonce the job has ended, as with any set.Tests
Integration, each on SQLite and PostgreSQL unless noted:
bulk_update_entrieswith 180 entity updates returns a set id and a queued job at once.get_jobshows the progress only move up, to 180 of 180, the set holds 180 operations, and the job succeeded.change_set_busy, and goes through once the job has ended.get_jobshows an agent its own job and refuses another agent's.Unit: four payloads the handler can't read each fail with
payload_invalid. Both tool providers pass the tool conformance suite.The full suite ran locally against a
postgres:17container as well as SQLite, and markdownlint passes. No new package and no new project reference.Checklist
v2