Skip to content

Read the desk's page parameter as text so a bad value shows the first page - #2647

Merged
pournasserian merged 1 commit into
v2from
2631-page-as-text
Oct 19, 2026
Merged

pournasserian merged 1 commit into
v2from
2631-page-as-text

Conversation

@pournasserian

Copy link
Copy Markdown
Member

Closes #2631

What

A Low finding from the independent review of #2568 (F-DSK, #2422). A page that didn't parse, such as abc or 99999999999, answered an empty 500 on the desk and on /security.

  • The desk and the security view read page as text and parse it with int.TryParse. A value that doesn't parse shows the first page, as 0 and negative values already did.

Why

  • Text, not int?. Blazor throws while binding a query value that doesn't parse, before the page can fall back. Reading text keeps the fallback in the page.

Tests

  • bUnit: page=abc, page=99999999999 and an empty page show the first page on both views.
  • Host: the same addresses answer 200 on both views.

dotnet build -warnaserror, the unit and bUnit suite and the desk host tests pass locally. No new package and no new project reference.

Checklist

  • Linked to an issue a maintainer has confirmed
  • Targets v2
  • Tests or docs updated where behaviour changed
  • No tool-generated co-author trailers or footers

@pournasserian pournasserian added this to the M1 Governance core milestone Oct 19, 2026
@pournasserian pournasserian added v2 FluentCMS v2 (v2 branch) type:bug Defect area:desk labels Oct 19, 2026
@pournasserian
pournasserian merged commit 3f4a695 into v2 Oct 19, 2026
2 checks passed
@pournasserian
pournasserian deleted the 2631-page-as-text branch October 19, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug Defect v2 FluentCMS v2 (v2 branch)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Read the desk's page parameter as text so a bad value shows the first page

1 participant