Repository navigation
Read the desk's page parameter as text so a bad value shows the first page - #2647
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2631
What
A Low finding from the independent review of #2568 (F-DSK, #2422). A
pagethat didn't parse, such asabcor99999999999, answered an empty 500 on the desk and on/security.pageas text and parse it withint.TryParse. A value that doesn't parse shows the first page, as 0 and negative values already did.Why
int?. Blazor throws while binding a query value that doesn't parse, before the page can fall back. Reading text keeps the fallback in the page.Tests
page=abc,page=99999999999and an emptypageshow the first page on both views.dotnet build -warnaserror, the unit and bUnit suite and the desk host tests pass locally. No new package and no new project reference.Checklist
v2