Repository navigation
Test agent isolation and every queue of the desk tools, and tell agents they see their own sets - #2648
Merged
Conversation
…ts they see their own sets Closes #2625.
… agents see stale facts of their types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2625
What
Follow-ups from the independent review of #2594 (F-DSK, #2422). No scoping leak was found; these close the test gaps and tighten what agents are told.
get_desk_counts,list_desk_queueandget_change_set_reviewsay an agent sees only the change sets it opened, so a count of 0 doesn't read as an empty desk.get_change_set_reviewreads the set and its moves again when the last move disagrees with the set's state, up to three times. A decision that commits between the two reads no longer gives an answer that disagrees with itself.ChangeSetMoves.StateAfternames the state each move leaves a set in. The review tool uses it, and a test ties it to the directory.ConnectedAgent.AnotherAgentAsyncconnects a second agent to the same host for tests.Why
Tests
On SQLite and PostgreSQL:
Another agent's sets are not counted, listed or readable over MCP, while that agent sees its own. This exercises the credential-id half of the
OpenedByfilter.Every queue through
list_desk_queue:recently_publishedlists newest first and leaves out a set published eight days earlier.revertedlists the reverted set.stale_factspages two and then one of three, with the total on both pages.No tool call appends an event,
get_change_set_reviewincluded.Every move the directory makes appends exactly one known move, and
StateAfternames the state the move left. The set goes through:All nine move names are seen.
dotnet build -warnaserror, the unit and bUnit suite and the desk, desk tools and queue tests on SQLite and PostgreSQL pass locally. No new package and no new project reference.Checklist
v2