Repository navigation
Keep the media form's base version and stop refused uploads filtering the library - #2651
Merged
Merged
Conversation
… on both providers, and name a page that hangs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2629
What
Follow-ups from the independent review of #2601 (F-MED, #2427).
BaseVersioncomes from the form being shown. A form refused for its own problems keeps the version it started from, so its next save is refused as a conflict instead of overwriting a change saved meanwhile.upload-error,upload-folder,upload-tags,upload-altandupload-caption, which no list filter reads.upload-droppednames it, and the form says to type it again, so the redirect stays well inside the server's request line limit.subanduploadedare read as text.subtakes1ortrue. A value that isn't a flag counts as false instead of failing the page with a 500.uploadedhas the same bug assub, so it is fixed here too.entityand other items asentry, as the log names them.UseMediaUploadLimitruns before the anti-forgery check. It reads and discards the declared body, then redirects back to the library.Why
Tests
sub=1lists subfolders, andsub=yesdoesn't.uploaded=abcshows the page without the upload note.entity, in bUnit.subflag takes 1 and true.SignedInPageTestsgives each page load a 30-second deadline that names the page. That test hung once on PostgreSQL in CI on v2, and passed on re-run, so the next failure says which page it was.dotnet build -warnaserror, the unit and bUnit suite and the media tests on SQLite and PostgreSQL pass locally. No new package and no new project reference.Checklist
v2