Repository navigation
Carry the set view's prerendered diff into the circuit and close its test gaps - #2657
Merged
Merged
Conversation
…test gaps Closes #2627.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2627
What
Follow-ups from the independent review of #2576 (F-DSK, #2422).
PersistentComponentState, and the circuit takes it back.ItemDiff.RestoreandValueDiff.Restorerebuild the diff model from what was kept, asChangeOperation.Restorealready does for operations.AdminLimitsholds both sizes.https://аpple.com/with a Cyrillic "а" shows(host xn--pple-43d.com). The address the link opens is unchanged.Why
Tests
dir="rtl".AsciiHostnames a look-alike host and leaves an ASCII host or an IPv6 address alone.dotnet build -warnaserror, the unit and bUnit suite, and the set view, review, keyboard and accessibility tests on SQLite and PostgreSQL pass locally. No new package and no new project reference.Checklist
v2