Repository navigation
Let people turn off single-key shortcuts and test the keyboard paths properly - #2661
Merged
Merged
Conversation
…r the page when storage refuses, and test the reload properly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2626
What
Follow-ups from the independent review of #2585 (F-DSK, #2422).
admin.jsshows the stored choice when the switch is rendered, after each enhanced navigation (enhancedload), and when the switch takes focus.The island's readiness (finding 7) stays as documented, as the issue says.
A letter that types another Latin letter on a non-QWERTY layout can still fire that letter's shortcut. That is existing behaviour, filed as #2662.
Tests
Browser:
admin.jsmade to ignore the stored choice, this test fails.bUnit: the dialogs list the new keys, and the switch is rendered on.
dotnet build -warnaserror, the unit and bUnit suite and the keyboard browser tests pass locally. No new package and no new project reference.Checklist
v2