Skip to content

Document the public CircleGenerator API - #37

Draft
faisalansari0367 wants to merge 1 commit into
flutter:mainfrom
faisalansari0367:docs/vector-math-circle-generator
Draft

Document the public CircleGenerator API#37
faisalansari0367 wants to merge 1 commit into
flutter:mainfrom
faisalansari0367:docs/vector-math-circle-generator

Conversation

@faisalansari0367

Copy link
Copy Markdown

Description

Adds public API docs for CircleGenerator (class and createCircle) and removes the public_member_api_docs ignore for circle_generator.dart, following the same pattern as #12 and #22.

Part of the ongoing vector_math doc migration tracked in flutter/flutter#186827.

Related Issues

Fixes part of flutter/flutter#186827

Tests

  • dart analyze — no issues found
  • dart test — all 252 tests pass

Docs-only change; no behavior modified.

Removes the public_member_api_docs ignore for circle_generator.dart
and documents the class and its public createCircle constructor
method, per the ongoing vector_math doc migration tracked in
flutter/flutter#186827.
@github-actions github-actions Bot added p: vector_math triage-framework Should be looked at in framework triage labels Aug 27, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request documents the public CircleGenerator API in the vector_math package. It removes the ignore rule for public member API documentation in circle_generator.dart, adds documentation comments to the CircleGenerator class and its createCircle method, and updates the package version to 2.4.3 in pubspec.yaml and CHANGELOG.md. There are no review comments, and I have no feedback to provide.

@stuartmorgan-g

Copy link
Copy Markdown
Collaborator

Thank you for your contribution! Because of the volume of PRs we receive, we require that new contributors use our checklist to guide them through critical steps in creating a Flutter PR. This PR's description is missing that checklist, so it is being marked as a Draft.

Please edit the PR description to add the checklist, then ensure that you have completed all of the steps. Once you've done that, please mark the PR as ready for review.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@stuartmorgan-g
stuartmorgan-g marked this pull request as draft September 1, 2026 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p: vector_math triage-framework Should be looked at in framework triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants