fix: block non-public URL targets - #3
Merged
Merged
Conversation
Owner
Author
|
Code review completed: no blocking findings in this focused change. CIDR boundaries, IPv4-mapped IPv6 handling, redirects, error behavior, and regression coverage were reviewed. GitHub Smoke passed. Residual DNS-rebinding risk predates this PR and is tracked separately so this address-range fix can remain focused. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Risk
Verification
npm run cipasses locallyVerification notes:
Local lint and all 6 smoke tests pass. The UI is unchanged, so desktop/mobile layout testing is not applicable.
Review and release
Rollback plan:
Revert this PR. No data migration or deployment step is involved.