fix: pin validated DNS addresses - #5
Merged
Merged
Conversation
fly1d
commented
Aug 11, 2026
fly1d
left a comment
Owner
Author
There was a problem hiding this comment.
Code review completed with no blocking findings. Verified: validated DNS answers are passed into the native connection lookup; redirect hosts are independently resolved and pinned; the connected socket address is checked; public IPv4/IPv6 boundaries remain allowed; no dependency was added; all 11 tests and the real HTTPS fetch pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Closes #4
Risk
Verification
npm run cipasses locallyVerification notes:
All 11 local checks pass. A real fetch of
https://example.com/also succeeded with TLS hostname validation, a 559-byte body, and the expected title. UI layout is unchanged.Review and release
Rollback plan:
Revert this PR. No data migration or dependency change is involved.