feat: ground unknown term summaries - #7
Merged
Conversation
fly1d
commented
Aug 11, 2026
fly1d
left a comment
Owner
Author
There was a problem hiding this comment.
Code review completed with no blocking findings. Verified: built-in terms return before any external request; unknown terms use only the fixed Chinese Wikipedia endpoint with a 3.5-second timeout; relevance indices are sorted before selection; disambiguation, malformed data, failures, and empty results are covered; source attribution and the external data flow are documented; no dependency was added; all 15 checks pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Closes #6
Risk
Verification
npm run cipasses locallyVerification notes:
All 15 local checks pass. Real API and service-level smoke tests covered
量子纠缠as a sourced result,Mercuryas a dynamic clarification, andMCPas an unchanged built-in result. CI uses mocked MediaWiki responses and does not require external network access. The only UI change is source tooltip/accessibility metadata; layout is unchanged.Review and release
Rollback plan:
Revert this PR. Unknown terms will return to the existing local generic template; no data migration or dependency rollback is required.