Skip to content

fix(worker): honour temporal-max-parallel-activities flag (EN-1228) #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
flemzord wants to merge 1 commit into from
Closed

fix(worker): honour temporal-max-parallel-activities flag (EN-1228) #191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions cmd/worker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,18 @@ func workerOptions(cmd *cobra.Command) fx.Option {

stack, _ := cmd.Flags().GetString(stackFlag)
temporalTaskQueue, _ := cmd.Flags().GetString(temporal.TemporalTaskQueueFlag)
temporalMaxParallelActivities, _ := cmd.Flags().GetInt(temporal.TemporalMaxParallelActivitiesFlag)
// The flag is registered as a float64 in go-libs; reading it with GetInt
// silently fails and yields 0, so the configured limit was never applied.
temporalMaxParallelActivities, _ := cmd.Flags().GetFloat64(temporal.TemporalMaxParallelActivitiesFlag)
topics, _ := cmd.Flags().GetStringSlice(topicsFlag)

return fx.Options(
stackClientModule(cmd),
temporalworker.NewWorkerModule(temporalTaskQueue, worker.Options{
TaskQueueActivitiesPerSecond: float64(temporalMaxParallelActivities),
// "max parallel activities" caps concurrency, which maps to
// MaxConcurrentActivityExecutionSize, not the queue-wide rate limit
// TaskQueueActivitiesPerSecond it was previously wired to.
MaxConcurrentActivityExecutionSize: int(temporalMaxParallelActivities),
}),
triggers.NewListenerModule(
stack,
Expand Down
Loading