Skip to content

fix(storage): index triggers_occurrences(trigger_id, date) (EN-1231) #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
flemzord wants to merge 1 commit into from
Closed

fix(storage): index triggers_occurrences(trigger_id, date) (EN-1231) #194

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions internal/storage/migrations.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,22 @@ var _migrations = []migrations.Migration{
return nil
},
},
{
// Migration 8 dropped the (trigger_id, event_id) primary key in favour
// of (id), leaving trigger_id unindexed. ListTriggersOccurrences filters
// WHERE trigger_id = ? and orders by date, so without this index every
// page is a sequential scan over an ever-growing table. Built
// CONCURRENTLY to avoid blocking writes during deploy.
Up: func(ctx context.Context, tx bun.IDB) error {
if _, err := tx.ExecContext(ctx, `
create index concurrently if not exists triggers_occurrences_trigger_id_date_idx
on triggers_occurrences (trigger_id, date);
`); err != nil {
return err
}
return nil
},
},
}

func Migrate(ctx context.Context, db *bun.DB) error {
Expand Down
Loading