Repository navigation
fix(scripts): stop expect_failure from passing vacuously - #18
Merged
Merged
Conversation
…ilure The negative-path assertions executed the description string as the command (exit 127) and passed vacuously; shift removes it so the function under test actually runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The publish-state test helper executed its description argument as the command (exit 127) instead of the function under test, so the three negative-path assertions — including the unparseable-429-timestamp guard this hardening campaign exists for — reported ok without testing anything. One-line
shiftfix; suite re-run: 36 passed, 0 failed, with the garbage-timestamp assertions now genuinely exercised.