Repository navigation
feat(runner): complete the remaining-work tracker — parity, intent fields, stdin mapping, diagnostics, docs - #20
Merged
Conversation
…s sanitized env summaries
… the remaining-work tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes out 100% of
docs/runner-remaining-work.md(areas 1–5). Area 6 stays deferred by decision, as the tracker requires.What landed
A1 — Parity closeout (
52ffcc4)parity_failureasserts an exact non-zero exit code, not just cross-runner equalityTokioRunnerOptions/builder mirrors the Duct options: configurable default timeout (no more hardcoded 60s) and toggleable command loggingConfiguredDuctRunner, the streaming path, andFakeRunner, with 4 intentionally-excluded rows enumerated inparity_tests.rsA2 — Command-intent extensions, all four rulings recorded (
2367b2d)stdin_bytes: Option<Vec<u8>>— implemented additively; included in FakeRunner matchingtimeout_policy— implemented; takes precedence overtimeout, old payloads serde-default to runner default; excluded from FakeRunner matchingpolicy.rs)OutputModeA3 — Duct stdin error mapping (
3e1dd3c,cb39a42)Error::StdinFailedwith kill-and-reap before returning, matching Tokiowrite_stdinso the contract holds unqualified on every path of both runnersA4 — Diagnostics hardening (
a6e3cfd)redact_logsdefault-true on both runners — logs never print unredacted args by defaultdisplay_env) on completion eventsA5 — Crate docs + tracker closeout (
2e9c6c8)clear_env/PATH footgun, redaction, output limitsdocs/runner-remaining-work.mdupdated: every item's final status with rulings and shasVerification
cargo test -p toride-runner --features 'duct-runner tokio-runner serde stream fake': 286 unit + 23 doctests pass (baseline 227 + 9)cargo fmt --checkclean; clippy at the recorded 2-warning pre-existing baseline, zero newcargo doc --no-depsclean;cargo check --workspace --all-targetsexit 0cb39a42)