Skip to content

fix: cast preg_match close offset to int in MetadataParser - #1

Merged
fsans merged 1 commit into
mainfrom
develop
Jul 12, 2026
Merged

fix: cast preg_match close offset to int in MetadataParser#1
fsans merged 1 commit into
mainfrom
develop

Conversation

@fsans

@fsans fsans commented Jul 12, 2026

Copy link
Copy Markdown
Owner

Summary

  • Cast $closeMatch[0][1] (from PREG_OFFSET_CAPTURE) to int before arithmetic in MetadataParser::findElements()
  • PREG_OFFSET_CAPTURE returns the offset as int|string depending on PHP version; the cast satisfies static analysis
  • Sibling fix to the earlier $offset cast on the same method

Test plan

  • composer test passes
  • composer analyse (PHPStan max) passes
  • composer check succeeds

@fsans
fix: cast preg_match close offset to int in MetadataParser
57e62a4 
PREG_OFFSET_CAPTURE returns the offset as int|string depending on
PHP version. Cast $closeMatch[0][1] to int before arithmetic to
satisfy static analysis.
@fsans
fsans merged commit 13a7df0 into main Jul 12, 2026
6 checks passed
fsans added a commit that referenced this pull request Jul 15, 2026
@fsans
Merge remote-tracking branch 'origin/main' to reconcile PR #1 merge
d95e16b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@fsans