update(major): publish package to github - #14
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR migrates the package publishing infrastructure from GitLab to GitHub. The changes update repository URLs, reorganize build scripts, and reconfigure the CI/CD workflow to publish packages to GitHub Packages instead of GitLab.
Key changes:
- Updated repository URLs from
getfundwavetofundwaveorganization - Refactored build scripts to separate CJS and ESM builds
- Modified CI/CD workflow to publish to GitHub Packages with proper authentication
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| package.json | Updated repository URLs to fundwave org and reorganized build scripts |
| .github/workflows/npm-publish.yml | Reconfigured workflow to publish to GitHub Packages instead of GitLab |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jsdoc-to-markdown@9.0.2 pulled in jsdoc@4.0.3, which calls the removed util.isRegExp() and crashes the docs step on Node 24 (the runner switched to Node 24 for npm OIDC trusted publishing). 9.1.3 resolves jsdoc@4.0.5, which uses lodash's isRegExp instead. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
- actions/checkout, actions/setup-node, and gh-action-bump-version were pinned to versions whose action runtime targets Node 20, which GitHub now force-upgrades to Node 24 with a deprecation warning on every run. Bumped to the latest releases that declare node24 as their runtime (checkout@v7, setup-node@v7, gh-action-bump-version@v12.0.0, github-app-token@v2.1.0). - Restored the "prepare" script (flagged in PR #14 review) so consumers installing this package via a git dependency get a built dist/, since dist/ is gitignored and only produced by the explicit CI build step otherwise. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
giriparus
approved these changes
Sep 7, 2026
giriparus
left a comment
giriparus
left a comment
There was a problem hiding this comment.
reviewed workflow and test changes ( updated urls to not rely on external APIs, started failing )
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upload package to github
Resolutions