Skip to content

Spellcheck in CI  #46

Description

@arminsabouri

To reduce the feedback loop for Spelling mistakes e.g #15 (review)_

Activity

  1. added
    help wantedExtra attention is needed
    nixPull requests that update nix code
    github_actionsPull requests that update GitHub Actions code
    on Oct 6, 2026
  2. arminsabouri commented on Oct 7, 2026

    @arminsabouri
    CollaboratorAuthor

    Leaving this open. We still need a general spell checker and to fix: #47 (comment)

  3. yuval-block commented on Oct 7, 2026

    @yuval-block
    Collaborator

    #47 doesn't close this but i think can be merged anyway so posting here, but i'm also fine with these changes being added to it

    IMO, and this applies to fungi monorepo and concurrent-psbt repo as well (cc @Mshehu5):

    • keep typos tool, it's useful for rust code (though maybe not as useful on this repo it doesn't hurt)
    • evaluate and add a flake check based on cspell - i think that'll cover python & rust docs & comments, nix comments and markdown files iiuc?
    • alternatively add cargo-spellcheck for rust docs checking (also not so useful for this repo specifically but doesn't hurt to be consistent)

    @arminsabouri is cspell what you meant in the call? codespell seems to be hosted service whereas cspell seems to be a reasonably popular typescript tool included in nixpkgs

  4. yuval-block commented on Oct 7, 2026

    @yuval-block
    Collaborator

    ah there seem to be multiple things called codespell... seems like something better left to an LLM to look into, going to stop opening tabs now

  5. bc1cindy commented on Oct 7, 2026

    @bc1cindy
    Member

    I'll also set the @oakagent to check and post typos in one comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    github_actionsPull requests that update GitHub Actions codegood first issueGood for newcomershelp wantedExtra attention is needednixPull requests that update nix code

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions