Repository navigation
Load built-in instruments into the plugin host from Add Track - #130
Merged
Merged
Conversation
The Add Track dialog queued only VST3/VST2/CLAP inserts for a host load, so a built-in instrument such as Drum Sampler opened an editor with no host instance behind it: dropped samples had nowhere to go and nothing played.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating an Instrument track from the Add Track dialog queued only VST3/VST2/CLAP inserts for a plugin-host load. A built-in instrument (e.g. Drum Sampler) was added to the track but never loaded, so its editor opened with no host instance: dropping a sample failed with
no plugin host holds instance insert-track-1-1and nothing could play.Built-ins supported by the audio bridge are now queued too;
load_bridge_insert_for_slotalready handled them.Validation:
cargo check -p sphere_ui_componentspasses. Not yet run in the app: sample drop onto a pad and MIDI playback still need a manual check on Linux. Tracks already created with the old build stay unloaded and need recreating.