Test files required after model parameters table updates. - #28
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Resolve the non-portable path, restore workflow logs, and correct the release-note wording.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR refreshes v0.38.0 integration-test fixtures after model-parameter table updates.
Changes:
- Migrates model-parameter fixtures and configurations to Astropy-table/ECSV formats.
- Regenerates scan grids, camera-efficiency results, simulations, and telescope configurations.
- Removes v0.38.0 workflow generation logs and updates the change note.
Review findings:
- Nit (3 votes): Correct the release-note wording to “tabulated simulation model data.”
- Moderate (1 vote): Normalize the developer-local absolute path in the production-grid fixture.
- Moderate (1 vote): Retain or regenerate
array_layouts.log. - Moderate (2 votes): Retain or regenerate the removed v0.38.0 workflow logs.
File summaries
| File | Summary |
|---|---|
simtools-tests/v0.38.0/integration_tests/log_files/validate_camera_efficiency_ssts_design_south.log |
Removed workflow generation log fixture. |
simtools-tests/v0.38.0/integration_tests/log_files/validate_camera_efficiency_mstx_nectarcam_north.log |
Removed workflow generation log fixture. |
simtools-tests/v0.38.0/integration_tests/log_files/validate_camera_efficiency_mstx_flashcam_south.log |
Removed workflow generation log fixture. |
simtools-tests/v0.38.0/integration_tests/log_files/validate_camera_efficiency_lsts02_south.log |
Removed workflow generation log fixture. |
simtools-tests/v0.38.0/integration_tests/log_files/validate_camera_efficiency_lstn02_north.log |
Removed workflow generation log fixture. |
simtools-tests/v0.38.0/integration_tests/log_files/simulate_prod_proton_20_deg_north_alpha.log |
Removed workflow generation log fixture. |
simtools-tests/v0.38.0/integration_tests/log_files/simulate_prod_gamma_40_deg_south.log |
Removed workflow generation log fixture. |
simtools-tests/v0.38.0/integration_tests/log_files/simulate_prod_gamma_20deg_north_alpha.log |
Removed workflow generation log fixture. |
simtools-tests/v0.38.0/integration_tests/log_files/simulate_flasher_simulation_lst_north.log |
Removed workflow generation log fixture. |
simtools-tests/v0.38.0/integration_tests/log_files/production_generate_scan_grid_horizontal.log |
Removed workflow generation log fixture. |
simtools-tests/v0.38.0/integration_tests/log_files/production_generate_grid_horizontal.log |
Removed workflow generation log fixture. |
simtools-tests/v0.38.0/integration_tests/log_files/pm_photoelectron_spectrum.log |
Removed workflow generation log fixture. |
simtools-tests/v0.38.0/integration_tests/log_files/num_gains.log |
Removed workflow generation log fixture. |
simtools-tests/v0.38.0/integration_tests/log_files/nsb_reference_spectrum.log |
Removed workflow generation log fixture. |
simtools-tests/v0.38.0/integration_tests/log_files/mirror_list.log |
Removed workflow generation log fixture. |
simtools-tests/v0.38.0/integration_tests/log_files/generate_array_config_beta_south_7.0.0.log |
Removed workflow generation log fixture. |
simtools-tests/v0.38.0/integration_tests/log_files/generate_array_config_alpha_north_7.0.0.log |
Removed workflow generation log fixture. |
simtools-tests/v0.38.0/integration_tests/log_files/generate_array_config_alpha_north_5.0.0.log |
Removed workflow generation log fixture. |
simtools-tests/v0.38.0/integration_tests/log_files/camera_filter_incidence_angle.log |
Removed workflow generation log fixture. |
simtools-tests/v0.38.0/integration_tests/log_files/array_layouts.log |
Removed workflow generation log fixture. |
simtools-tests/v0.38.0/integration_tests/log_files/array_element_position_utm.log |
Removed workflow generation log fixture. |
simtools-tests/v0.38.0/integration_tests/log_files/array_element_position_ground.log |
Removed workflow generation log fixture. |
simtools-tests/v0.38.0/integration_tests/generated/sim_telarray_configurations/7.0.0/CTAO-South-CTAO-South-Beta.cfg |
Regenerated telescope configuration. |
simtools-tests/v0.38.0/integration_tests/generated/sim_telarray_configurations/7.0.0/CTAO-North-CTAO-North-Alpha.cfg |
Regenerated array configuration. |
simtools-tests/v0.38.0/integration_tests/generated/sim_telarray_configurations/7.0.0/CTAO-MSTS-01.cfg |
Regenerated telescope configuration. |
simtools-tests/v0.38.0/integration_tests/generated/sim_telarray_configurations/7.0.0/CTAO-MSTN-01.cfg |
Regenerated telescope configuration. |
simtools-tests/v0.38.0/integration_tests/generated/sim_telarray_configurations/7.0.0/CTAO-LSTS-02.cfg |
Regenerated telescope configuration. |
simtools-tests/v0.38.0/integration_tests/generated/sim_telarray_configurations/7.0.0/CTAO-LSTN-02.cfg |
Regenerated telescope configuration. |
simtools-tests/v0.38.0/integration_tests/generated/sim_telarray_configurations/7.0.0/CTAO-LSTN-01.cfg |
Regenerated telescope configuration. |
simtools-tests/v0.38.0/integration_tests/generated/sim_telarray_configurations/5.0.0/CTAO-North-alpha.cfg |
Regenerated array configuration. |
simtools-tests/v0.38.0/integration_tests/generated/sim_telarray_configurations/5.0.0/CTAO-MSTN-01.cfg |
Regenerated telescope configuration. |
simtools-tests/v0.38.0/integration_tests/generated/sim_telarray_configurations/5.0.0/CTAO-LSTN-02.cfg |
Regenerated telescope configuration. |
simtools-tests/v0.38.0/integration_tests/generated/sim_telarray_configurations/5.0.0/CTAO-LSTN-01.cfg |
Regenerated telescope configuration. |
simtools-tests/v0.38.0/integration_tests/generated/production_grid_points_horizontal.ecsv |
Regenerated production grid; provenance path requires normalization. |
simtools-tests/v0.38.0/integration_tests/generated/model_parameters/nsb_reference_spectrum-1.0.0-OBS-South.ecsv |
Updated South NSB reference fixture. |
simtools-tests/v0.38.0/integration_tests/generated/model_parameters/mirror_list-2.0.0.json |
Updated mirror-list metadata. |
simtools-tests/v0.38.0/integration_tests/generated/model_parameters/mirror_list-2.0.0.ecsv |
Added schema-validated mirror table. |
simtools-tests/v0.38.0/integration_tests/generated/model_parameters/mirror_CTA-N-LST1_v2019-03-31_rotated.dat |
Regenerated mirror fixture. |
simtools-tests/v0.38.0/integration_tests/generated/model_parameters/camera_filter_photon_incident_angle-1.0.0.ecsv |
Added camera-filter table fixture. |
simtools-tests/v0.38.0/integration_tests/generated/camera_efficiency/camera_efficiency_summary_South_SSTS-design_za20.0deg_azm000deg.yml |
Regenerated camera-efficiency summary. |
simtools-tests/v0.38.0/integration_tests/generated/camera_efficiency/camera_efficiency_summary_South_MSTx-FlashCam_za0.0deg_azm000deg.yml |
Regenerated camera-efficiency summary. |
simtools-tests/v0.38.0/integration_tests/generated/camera_efficiency/camera_efficiency_summary_South_LSTS-02_za0.0deg_azm000deg.yml |
Regenerated camera-efficiency summary. |
simtools-tests/v0.38.0/integration_tests/generated/camera_efficiency/camera_efficiency_summary_North_MSTx-NectarCam_za0.0deg_azm000deg.yml |
Regenerated camera-efficiency summary. |
simtools-tests/v0.38.0/integration_tests/generated/camera_efficiency/camera_efficiency_summary_North_LSTN-02_za0.0deg_azm000deg.yml |
Regenerated camera-efficiency summary. |
simtools-tests/v0.38.0/integration_tests/generated/bias_curve_scan_grids/proton/scan_grid.ecsv |
Regenerated proton scan grid. |
simtools-tests/v0.38.0/integration_tests/generated/bias_curve_scan_grids/proton/scan_config.yaml |
Updated proton scan configuration. |
simtools-tests/v0.38.0/integration_tests/generated/bias_curve_scan_grids/proton/overwrite_proton_asum220.yaml |
Updated proton scan fixture. |
simtools-tests/v0.38.0/integration_tests/generated/bias_curve_scan_grids/nsb/scan_grid.ecsv |
Regenerated NSB scan grid. |
simtools-tests/v0.38.0/integration_tests/generated/bias_curve_scan_grids/nsb/scan_config.yaml |
Updated NSB scan configuration. |
simtools-tests/v0.38.0/integration_tests/generated/bias_curve_scan_grids/nsb/overwrite_nsb_asum220.yaml |
Updated NSB scan fixture. |
simtools-tests/v0.38.0/integration_tests/config_files/validate_camera_efficiency_mstx_nectarcam_north.config.yml |
Updated workflow input for generated NSB data. |
simtools-tests/v0.38.0/integration_tests/config_files/validate_camera_efficiency_mstx_flashcam_south.config.yml |
Updated workflow input for generated NSB data. |
simtools-tests/v0.38.0/integration_tests/config_files/validate_camera_efficiency_lstn02_north.config.yml |
Updated workflow input for generated NSB data. |
simtools-tests/v0.38.0/integration_tests/config_files/production_generate_scan_grid_horizontal.config.yml |
Updated scan-grid configuration. |
simtools-tests/v0.38.0/integration_tests/config_files/pm_photoelectron_spectrum.config.yml |
Updated photoelectron-spectrum configuration. |
simtools-tests/v0.38.0/integration_tests/config_files/nsb_reference_spectrum_south.config.yml |
Updated South NSB configuration. |
simtools-tests/v0.38.0/integration_tests/config_files/nsb_reference_spectrum_north.config.yml |
Added North NSB configuration. |
simtools-tests/v0.38.0/integration_tests/config_files/mirror_list.config.yml |
Migrated mirror-list export configuration. |
simtools-tests/v0.38.0/integration_tests/config_files/camera_filter_incidence_angle.config.yml |
Updated camera-filter export configuration. |
docs/changes/28.feature.md |
Documents the model-parameter updates; wording correction remains required. |
Review details
- Files reviewed: 10/76 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See updates in