Unit test improvements - #2557
Draft
GernotMaier wants to merge 6 commits into
Draft
Unit test improvements #2557GernotMaier wants to merge 6 commits into
GernotMaier wants to merge 6 commits into
Conversation
GernotMaier
added
no-changelog-needed
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The event-limit test misses a concrete multi-telescope overflow case, and reporting field type checks were weakened.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Improves unit-test coverage and assertion precision across simulation, reporting, model, and camera components.
Changes:
- Adds edge-case and numerical behavior tests.
- Strengthens mock forwarding and generated-report assertions.
- Standardizes edited file-writing tests on
tmp_test_directory.
| File | Description |
|---|---|
tests/unit_tests/simtel/test_simtel_event_reader.py |
Adds missing-data, logging, and event-limit cases. |
tests/unit_tests/reporting/test_docs_read_parameters.py |
Updates temporary paths and report assertions. |
tests/unit_tests/production_configuration/test_monte_carlo_statistics_estimator.py |
Tests spectral integration and weighting. |
tests/unit_tests/model/test_model_parameter.py |
Strengthens state preservation and schema-call checks. |
tests/unit_tests/model/test_mirrors.py |
Removes a duplicate mirror test. |
tests/unit_tests/corsika/test_corsika_output_validator.py |
Verifies argument forwarding and event tolerance. |
tests/unit_tests/camera/test_camera_efficiency.py |
Tests analysis prerequisites and derived efficiencies. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: GernotMaier <14001688+GernotMaier@users.noreply.github.com>
Co-authored-by: GernotMaier <14001688+GernotMaier@users.noreply.github.com>
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only test improvements, no change in production code.