Skip to content

revert(#425): run read root fields concurrently on pooled connections - #498

Merged
gazorby merged 1 commit into
mainfrom
revert/475-concurrent-reads
Oct 13, 2026
Merged

gazorby merged 1 commit into
mainfrom
revert/475-concurrent-reads

Conversation

@gazorby

@gazorby gazorby commented Oct 12, 2026

Copy link
Copy Markdown
Owner

Description

Reverts #475.

This removes concurrent execution of read root fields: StrawchemyExecutionContext, the StrawchemyConfig.read_session_getter option, the read_only argument of Strawchemy.field, and the Strawchemy.read_session/write_session scopes, along with their tests and the "concurrent reads" section of the async docs. None of it shipped in a release. The intermittent serial-mutation failure investigated in #497 originates in graphql-core 3.3's subfield cache, not in this feature, so #497 stays open independently.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

📚 Documentation preview removed.

@greptile-apps

greptile-apps Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[High impact] The PR appears safe to merge as an intentional revert of an unreleased feature.

Summary

Reverts concurrent reads on pooled connections and restores reads through the request session.

  • Strawchemy runs generated fields through the configured request session.

gazorby states that these APIs never shipped. gazorby also identifies the intermittent serial-mutation failure as a separate graphql-core cache issue and leaves #497 open.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Sibling root fields] --> B[Request session]
  B --> C[Acquire shared session lock]
  C --> D[Run repository operation]
  D --> E[Release lock]
Loading

Reviews (1) · Last reviewed commit: "revert(#425): run read root fields concu..." · Reviewed by Greptile

@codecov

codecov Bot commented Oct 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.02%. Comparing base (125382d) to head (c264716).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #498      +/-   ##
==========================================
- Coverage   97.11%   97.02%   -0.10%     
==========================================
  Files          92       90       -2     
  Lines        8419     8230     -189     
  Branches     1151     1133      -18     
==========================================
- Hits         8176     7985     -191     
- Misses        145      146       +1     
- Partials       98       99       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@gazorby
gazorby merged commit 4ec53ae into main Oct 13, 2026
124 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant