Repository navigation
Conversation
The polyfill reads fenv_t's __control and __mxcsr fields, which exist only on Intel. On Apple Silicon fenv_t has __fpcr/__fpsr instead, so debug.cpp fails to compile. The callers are already guarded by __x86_64__, so the polyfill is unused on arm64. Fixes genetics-statistics#287
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #287.
The
feenableexcept/fedisableexceptpolyfill insrc/debug.cppreads the x86 fieldsfenv_t.__controland__mxcsr, which don't exist on Apple Silicon, so the build fails there. Its only callers, inenable_segfpe()/disable_segfpe(), are already inside#if defined(__x86_64__). This adds the same condition to the polyfill's guard. Nothing changes on Linux or on Intel Macs.Tested on macOS 14 (arm64) with Apple clang and Homebrew GSL and OpenBLAS: it builds, and
test/dev_tests.rbpasses (4 runs, 21 assertions, 0 failures).The
C/C++ CIworkflow was already failing onmaster(ce5e778) before this change.Claude found this fix, built and tested it, and wrote this description. I can confirm that GEMMA didn't build on my M1 Mac before this change and it does now.