fix(home): recent images are live, and they open - #202
Merged
Merged
Conversation
"are the recent images in the dashboard home view updated? and they are also thumbnail only like, and not able to click them really." Neither. The strip — latest projection per embryo across recent sessions — refreshed only on entering Home, at most every 15 s, and never on the event that changes it: a volume landing. During a run it was as stale as the last time you looked away. And the tiles were divs: an image with a title attribute and nothing to press. Now a volume landing (or an overview frame, or a run ending) redraws the strip if Home is on screen, and marks it stale otherwise so the next entry skips the throttle. And a tile is a button that opens the Lightbox at that image, with the others alongside. The Lightbox knew images only by store uid, and these are served per session by URL — which is why nobody had wired it. It opens by url now too, in all three places it chooses a src. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Neither, as it stood.
Not updated. The strip — latest projection per embryo across recent sessions — refreshed only on entering Home, at most every 15 s, and never on the event that changes it. During a run it was as stale as the last time you looked away. Now
VOLUME_ACQUIRED,IMAGE_ACQUIREDandACQUISITION_COMPLETEDredraw it (1.5 s debounce) while Home is on screen, and mark it stale otherwise so the next entry skips the throttle.Not clickable. The tiles were
<div><img>with atitle. A tile is now a button that opens the Lightbox at that image with the others alongside, and carries itsembryo · tNcaption on the tile. The Lightbox only knew images by storeuid, and these are served per session by URL — which is why nobody had wired it; it opens byurlnow too, in all three places it chooses asrc.Verified in a headless browser with the routes stubbed: two tiles render as buttons with captions and a pointer cursor; clicking the second opens the Lightbox on
/api/sessions/s1/projection?embryo=embryo_2&t=11; aVOLUME_ACQUIREDwhile Home is showing triggers a second fetch of the strip. Five source guards intests/test_home_recent_images.py.🤖 Generated with Claude Code