feat(acquisition): a resumed session comes back on what it was running - #208
Merged
Merged
Conversation
"when resume a session, the what to run ui/ux is in default view - not the ones i had selected for that session that i have resumed." #203 put the plan's fields back; the pane still came back on Single volume / All subjects whatever the session had been doing. The plan kept with the session now records "what to run" — the set (all subjects or the selected embryos, sent by the pane with both kinds of start) and the mode (adaptive, or which saved tactic it was) — and the pane puts both back on entry: the selected embryos re-selected and Selected (n) lit, the mode's panel open, the saved tactic picked. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#203 put the plan's fields back; the pane still came back on Single volume / All subjects whatever the session had been doing.
The plan kept with the session (
acquisition.yaml) now records what to run:scope: all | selectedplus the embryo ids, sent by the pane with both kinds of start (adaptive and saved tactic);adaptive, orlibrarywith the saved tactic's id (the run-tactic route stampslibrary_idon the instantiated tactic; the executor keeps it).On entry the pane puts both back: the selected embryos are re-selected (shared selection included, so the other panes follow), Selected (n) is lit, the mode's panel is open, and for a library run the saved tactic is picked. Unknown embryo ids are dropped. As with the plan fields, this happens once per page life and never over something the operator has already touched.
Verified headless: a plan with
scope: selectedfor embryos 2 and 3 andmode: adaptivebrings the pane up with Selected (2) lit and the adaptive panel open. Eight tests intests/test_what_to_run_restored.py.🤖 Generated with Claude Code