Skip to content

Support parse POINTZ, POINTM and POINTZM - #113

Merged
michaelkirk merged 1 commit into
georust:mainfrom
ariesdevil:dev
Jun 21, 2024
Merged

Support parse POINTZ, POINTM and POINTZM#113
michaelkirk merged 1 commit into
georust:mainfrom
ariesdevil:dev

Conversation

@ariesdevil

@ariesdevil ariesdevil commented Feb 7, 2024

Copy link
Copy Markdown
Contributor
  • I agree to follow the project's code of conduct.
  • I added an entry to CHANGES.md if knowledge of this change could be valuable to users.
  • I ran cargo fmt

@ariesdevil ariesdevil mentioned this pull request Feb 7, 2024
Merged
11 tasks
lnicola
lnicola reviewed Feb 7, 2024
View reviewed changes
Comment thread src/lib.rs Outdated
lnicola
lnicola reviewed Feb 7, 2024
View reviewed changes
Comment thread src/lib.rs Outdated
@ariesdevil
ariesdevil force-pushed the dev branch 2 times, most recently from aafbc8c to eed7f42 Compare February 7, 2024 11:02
lnicola
lnicola reviewed Feb 7, 2024
View reviewed changes
Comment thread src/lib.rs Outdated
@lnicola

lnicola commented Feb 7, 2024

Copy link
Copy Markdown
Member

I guess this will make the conversion to geo-types lossy. I don't think Z/M are available there, so there's not much you can do, just wanted to point that out.

@ariesdevil

ariesdevil commented Feb 7, 2024

Copy link
Copy Markdown
Contributor Author

I guess this will make the conversion to geo-types lossy. I don't think Z/M are available there, so there's not much you can do, just wanted to point that out.↳

Thanks point it out, I see Coord in geo-types only support x and y, I think it needs to be refactored later.

lnicola
lnicola reviewed Feb 7, 2024
View reviewed changes
Comment thread src/lib.rs Outdated
lnicola
lnicola reviewed Feb 7, 2024
View reviewed changes
Comment thread src/lib.rs Outdated
lnicola
lnicola reviewed Feb 7, 2024
View reviewed changes
Comment thread src/lib.rs Outdated
@ariesdevil

ariesdevil commented Feb 7, 2024

Copy link
Copy Markdown
Contributor Author

Fixed, PTAL again.

lnicola
lnicola approved these changes Feb 7, 2024
View reviewed changes

@lnicola lnicola left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You didn't add that comment about matches!, but whatever 😀.

@ariesdevil

ariesdevil commented Feb 7, 2024

Copy link
Copy Markdown
Contributor Author

You didn't add that comment about matches!, but whatever 😀.↳

Sorry, I forgot it🤔

michaelkirk
michaelkirk approved these changes Jun 21, 2024
View reviewed changes

@michaelkirk michaelkirk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that this sat here so long!

@michaelkirk
michaelkirk merged commit 2f1f44f into georust:main Jun 21, 2024
@ariesdevil
ariesdevil deleted the dev branch June 22, 2024 16:36
@michaelkirk

michaelkirk commented Jul 17, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

We've misspelled POINT Z, POINT M, and POINT ZM. See #114

Can you take a look @ariesdevil?

Otherwise I think we should revert this.

@michaelkirk michaelkirk mentioned this pull request Jul 17, 2024
Closed
@kylebarron kylebarron mentioned this pull request Jul 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@urschrei urschrei urschrei left review comments
@lnicola lnicola lnicola approved these changes
@michaelkirk michaelkirk michaelkirk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ariesdevil @lnicola @michaelkirk @urschrei