feat: don't copy flatpaks to extra location - #73
Merged
Merged
Conversation
Up to standards ✅🟢 Issues
|
Member
|
tested the ISO.
|
We can't use /var as an upperdir as the iso already sets up things in a way so that is already for overlayfs ``` mount: /var/lib/flatpak: fsconfig() failed: overlay: filesystem on /var/overlay/flatpak not supported as upperdir. ``` ``` findmnt / TARGET SOURCE FSTYPE OPTIONS / LiveOS_rootfs overlay rw,relatime,seclabel,lowerdir=/run/rootfsbase,upperdir=/run/overlayfs,workdir=/run/ovlwork,uuid=on ``` fixes: #72
renner0e
force-pushed
the
no-copy-flatpak
branch
from
August 24, 2026 22:09
066d7c2 to
d1d1b92
Compare
Member
Author
|
changed things, might work now, have only edited the unit on the live system, explanation in commit EDIT: didn't test a built iso but installing showtime and the installation didn't carry it over so I guess it works |
Member
Author
|
so welcome center still crashes and it is the same behavior as ublue-os/aurora#2624 on the installed system. I can't reproduce this on my system. |
renner0e
commented
Aug 25, 2026
Member
|
Can confirm the flatpak stuff works on the ISOs |
We should probably just do it this way, if for whatever reason it isn't mounted then it won't fail now
renner0e
marked this pull request as ready for review
August 26, 2026 00:00
Member
Author
|
needs: #80 |
inffy
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #72
see commits
complete shot in the dark, might not work at all
seems like it reduced build time from 20min to roughly 11 minutes.