Repository navigation
Refine reader navigation with separate translation and passage pickers - #11
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The combined navigation dropdowns made ordinary book/chapter changes cumbersome and mixed them with infrequent translation and appearance choices. This implements the maintainer's bot mini-app navigation pattern across the shared Flutter reader (Android, iOS/iPadOS, web, Windows, macOS and Linux).
Validation on the final implementation:
The delayed Search Open regression now checks immediate request invalidation and accepts only the new query after its legitimate debounce. This fixes a timing-sensitive assertion without changing search behavior.
Hosted Flutter CI run #80 passed on final head
22b758f38073938378e0fb4db4eac71ba0d25cb7: all 15 applicable jobs succeeded. This includes Android APK/AAB, unsigned iOS device/simulator, Web, Windows, macOS and Linux packages; native acceptance on Android phone/tablet, iPhone/iPad, Windows, macOS and Linux; and all six Chromium/Firefox/WebKit journeys across standard and isolated hosting. The browser harness uses the new accessible passage heading and retains its persistence/offline assertions. Five signing-related jobs were skipped as configured. Physical-device touch, VoiceOver/TalkBack, human language review and signing/store distribution remain separate gates. Details are in docs/TESTING.md. The React reference was inspected at 555008554d46e174dfdfb41e3bdc578d2a62a66e; this PR changes only the requested Flutter app repository.