Repository navigation
Conversation
## Context The alert threshold contract gained a `notify_on` field, an array of `triggered`/`resolved` that selects which transitions a threshold notifies on. It applies to subscription and wallet alerts and is not available on recurring thresholds. ## Description `notify_on` was added to the `AlertThreshold` request model and the `AlertThresholdResponse` response model. The wallet alert fixture and test were updated to cover it. The `alert.resolved` webhook event is not modeled: the Python client does not model webhook payloads.
vincent-pochet
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The Alert Resolution feature in lago-api adds opt-in resolution notifications. Each alert threshold gains a
notify_onarray selecting which transitions it notifies on (triggered, and optionallyresolved).Description
notify_on, an optional list of strings, was added to theAlertThresholdrequest model and theAlertThresholdResponseresponse model. The wallet-alert fixture and client test cover the new field.Depends on the OpenAPI contract in getlago/lago-openapi#585.
Part of ING-512.