Repository navigation
fix: forward timeout in child find_all - #428
Merged
Merged
Conversation
FindAllChildrenCommandMixin.find_all took a misspelled `timetour` argument and never passed it to the request, so the twelve child listings used the 5s httpx default instead of DEFAULT_TIMEOUT. Add `timeout` with the DEFAULT_TIMEOUT default and forward it. Keep `timetour` as a deprecated keyword-only alias; forwarding it as is would disable the timeout through its None default. Closes #410 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
toommz
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
FindAllChildrenCommandMixin.find_allaccepts a misspelledtimetourargument and never forwards it. The twelve child listings (customer_invoices,plan_charges, ...) ignore the caller's timeout and fall back to the 5 second httpx default, instead of the 10 secondDEFAULT_TIMEOUTevery other mixin uses.Description
timeoutargument to childfind_all, defaulting toDEFAULT_TIMEOUTlikeFindAllCommandMixin.find_all.timetouras a keyword-only alias that emits aDeprecationWarning.timetouris not forwarded as is: itsNonedefault would disable the httpx timeout entirely. A positional third argument keeps working and now maps totimeout.Behavior change to be aware of
closes #410
🤖 Generated with Claude Code