Skip to content

fix(i18n): only check calls to translators, not every name starting with t - #863

Merged
EtienneLescot merged 1 commit into
integration/demo-never-uglyfrom
fix/i18n-check-translator-callees
Sep 27, 2026
Merged

EtienneLescot merged 1 commit into
integration/demo-never-uglyfrom
fix/i18n-check-translator-callees

Conversation

@EtienneLescot

@EtienneLescot EtienneLescot commented Sep 27, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

npm run i18n:check failed on the integration branch: the key check matched any callee starting with t, so tierOutputDims("source") (from #861) read as a translation call with a missing key.

A callee now counts when the file binds it to useScopedT, or when it is named like a translator handed in as a prop or parameter: t, or t plus a capital (tCommon).

Testing

  • node scripts/i18n-check.mjs: passes, 874 literal keys checked.
  • Mutation check: unknown keys through ts (bound), tCommon and t are still reported; trimSomething("x") is ignored.

🤖 Generated with Claude Code

…ith t

The key check matched \b(t[A-Z]?\w*)\( and so read tierOutputDims("source") as a translation call, failing i18n:check on the integration branch. A callee now counts when the file binds it to useScopedT, or when it is named like a translator handed in as a prop: t, or t plus a capital. Checked by mutation: unknown keys through ts, tCommon and t still fail; trimSomething("x") is ignored.
@coderabbitai

coderabbitai Bot commented Sep 27, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: cc6b7a35-a620-426f-a4ba-b82f274a25cb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@EtienneLescot
EtienneLescot merged commit 2873dc6 into integration/demo-never-ugly Sep 27, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant