fix(i18n): only check calls to translators, not every name starting with t - #863
Merged
EtienneLescot merged 1 commit intoSep 27, 2026
Conversation
…ith t
The key check matched \b(t[A-Z]?\w*)\( and so read tierOutputDims("source") as a translation call, failing i18n:check on the integration branch. A callee now counts when the file binds it to useScopedT, or when it is named like a translator handed in as a prop: t, or t plus a capital. Checked by mutation: unknown keys through ts, tCommon and t still fail; trimSomething("x") is ignored.
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm run i18n:checkfailed on the integration branch: the key check matched any callee starting witht, sotierOutputDims("source")(from #861) read as a translation call with a missing key.A callee now counts when the file binds it to
useScopedT, or when it is named like a translator handed in as a prop or parameter:t, ortplus a capital (tCommon).Testing
node scripts/i18n-check.mjs: passes, 874 literal keys checked.ts(bound),tCommonandtare still reported;trimSomething("x")is ignored.🤖 Generated with Claude Code