Repository navigation
test(ci): cover missing cosign installer guard - #26
Merged
Merged
Conversation
Signed-off-by: Louis Deconinck <louis.dck@gmail.com> Assisted-by: Codex
Maxerns
approved these changes
Sep 10, 2026
Maxerns
left a comment
Maxerns
left a comment
Contributor
There was a problem hiding this comment.
Thanks @LouisDeconinck verified both legs against the installers ill approve the ci now and merge when its green
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24.
Add focused offline CI coverage for the installers' existing missing-
cosignprecondition on Ubuntu and Windows. The tests isolate executable lookup, intercept download attempts, verify the exact error, and assert that installation and GitHub output files remain untouched.Validation:
git diff --checkpassed.AI assistance: Codex assisted with implementation and test drafting; the patch was reviewed before submission.