Repository navigation
test(ci): cover checksum selection from multi-file manifests - #32
Merged
Maxerns merged 1 commit intoSep 13, 2026
Merged
Conversation
Extend the reject-tampered-checksum job so both helpers select the exact asset name from manifests that also list unrelated files and a near-match sotto-fixture.sigstore.json entry. The fixture entry is exercised at the beginning, middle, and end of the manifest, in both plain and binary-mode '*' forms, while a manifest without it still fails the cardinality guard. Fixes getsotto#28 Signed-off-by: Louis Deconinck <louis.dck@gmail.com>
Maxerns
approved these changes
Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #28
What
Adds multi-file-manifest coverage inside the existing
reject-tampered-checksumjob — no new jobs, no network. On both POSIX and Windows legs, temporary manifests place the target asset at the beginning, middle, and end among near-match (sotto-fixture.sigstore.json) and unrelated (sotto-v0.4.0-...tar.gz) entries, including the*binarymarker form in last position; a manifest with only near-match/unrelated names asserts the exacterror: sotto-fixture must appear exactly once in SHA256SUMSfailure.Testing
The POSIX step's run block was executed locally and passes on both the
sha256sumand the PATH-restrictedshasumfallback path; the negative case produces the exact contract error. The Windows leg mirrors the existingGet-FileHash/Set-Contentpatterns; CI will confirm. YAML parses cleanly.