Repository navigation
docs: add pull request template - #41
Merged
Merged
Conversation
Maxerns
requested changes
Sep 16, 2026
Maxerns
left a comment
Maxerns
left a comment
Contributor
There was a problem hiding this comment.
Thanks @Rayan-and-beyond this matches #14 exactly.
The PR has the summary, Closes #, test plan, and the DCO checkbox copied verbatim, with nothing extra added. CI is fully green too.
Only blocker is the missing sign-off on the commit. Please run:
git commit --amend -s
git push --force-with-leaseOnce that’s done, I’ll merge.
Rayan-and-beyond
force-pushed
the
add-pr-template
branch
from
September 16, 2026 16:47
b0f7f71 to
5aed601
Compare
Signed-off-by: Rayan-and-beyond <263488867+Rayan-and-beyond@users.noreply.github.com>
Rayan-and-beyond
force-pushed
the
add-pr-template
branch
from
September 17, 2026 13:32
5aed601 to
1f355ba
Compare
Contributor
Author
|
Updated the commit sign-off and force-pushed the branch. Thanks for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
.github/pull_request_template.mdso GitHub's PR form reminds contributors to sign off commits.Closes #14
Test plan
docs only
git commit -s/ Developer Certificate of Origin)Notes
Follows the exact spec from the issue: one-line summary,
Closes #, a short test plan section, and a DCO sign-off checkbox, in that order. No CI check, DCO app, or CODEOWNERS added — explicitly out of scope per the issue.