Repository navigation
docs(cli): explain set input modes and newline handling - #607
Merged
Merged
Conversation
Signed-off-by: Mohamed Ajab <mohamedajab8@gmail.com>
Maxerns
marked this pull request as ready for review
October 24, 2026 21:05
Maxerns
approved these changes
Oct 24, 2026
Maxerns
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for this, it covers #596 well. I checked the wording against read_value and the
Set path and it holds: no trimming on stdin, prompt by default, unlock still required, and
machine tokens genuinely do not apply here. I ran fmt, the new help test and the rendered set --help here and all is clean and readable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Explain the hidden prompt, piped input and file input in
sotto set --help.Closes #596
Adds POSIX examples for the prompt, a complete file value and a synthetic printf pipeline. Explains that stdin preserves line endings and trailing newlines, is not dotenv import, and does not replace local setup or unlocking. Keeps the warning about credentials in shell history and adds process arguments to it.
Adds a focused
Cli::command()help test. Input handling, storage and encryption are unchanged.Validation:
Checked the wording against
Command::Set,read_value()and the existing help-test pattern.git diff --checkpassed.Rust/Cargo is unavailable locally, so I have not run the Rust test, rustfmt, or rendered
sotto set --help. This is a draft pending those checks and a readability check of the rendered help. No real secrets were used.I signed off every commit (
git commit -s/ Developer Certificate of Origin).