Repository navigation
Conversation
…ff-stripe' into fix/expand-stripe-invoice-paid-off-stripe
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The first Stripe sandbox run after #706 reached invoice history but failed to decode
amount_paid_off_stripe. Stripe documents this as an includable Invoice field, so a normal invoice GET omits it unless requested withexpand[]. The reader correctly requires the value to distinguish Stripe settlement from payment outside Stripe; it just was not requesting it.What changed
Invoice detail reads now request
expand[]=amount_paid_off_stripe. A loopback test asserts the query, and the Stripe resource field matrix records the expansion requirement.Verification
cargo fmt --checkcargo test -p sotto-server --test cloud_provider_stripe_http— 67 passedcargo clippy -p sotto-server --test cloud_provider_stripe_http -- -D warningsgit diff --checkThe live sandbox workflow 40132813092 exposed the missing expansion. The sandbox contract has not yet been rerun with this change; that workflow is restricted to
main, so rerun it after merge.