Docs: use a self-hosted CodeQL logo instead of deprecated GHIcons - #22516
Open
redsun82 wants to merge 1 commit into
Open
Docs: use a self-hosted CodeQL logo instead of deprecated GHIcons#22516redsun82 wants to merge 1 commit into
redsun82 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The relative asset path and decorative-image semantics are correct for the published documentation layout.
Review tier: Balanced
Findings: None
What changed in this PR
Updates the documentation landing page to replace a broken GHIcons-hosted logo.
Changes:
- Uses the Primer Octovisuals CodeQL asset.
- Marks the decorative image with empty alternative text.
| File | Description |
|---|---|
docs/codeql/index.html |
Updates the landing-page logo source and accessibility metadata. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
jacknojo
previously approved these changes
Sep 7, 2026
jacknojo
left a comment
jacknojo
left a comment
Contributor
There was a problem hiding this comment.
Looks good, but it's not 404ing for me?
curl --url 'https://ghicons.github.com/assets/images/blue/svg/Code%20QL.svg'
<svg width="56" height="56" xmlns="http://www.w3.org/2000/svg">...
GHIcons is deprecated and the hot-linked URL now 404s. The replacement `code-ql` icon is hosted alongside the site's other assets, so the `../` path matches the nav links already in this file. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
redsun82
force-pushed
the
redsun82-octovisuals-docs-logo
branch
from
September 7, 2026 08:20
48e62f6 to
f5eec51
Compare
Contributor
Author
sorry, wrong PR description, it did 404 shortly in the past, but we temporarily reinstated the icons to avoid that. I updated the PR description accordingly. |
redsun82
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/codeql/index.htmlhot-linked the CodeQL logo fromghicons.github.com. GHIcons is deprecated and that URL will eventually 404, so the logo on https://codeql.github.com/docs/ would become broken.This points the
<img>at the same artwork hosted alongside the site's other assets in the publication repo that servescodeql.github.com, so the page no longer depends on a deprecated host. The logo itself is unchanged — this is a like-for-like move, not a redesign.