Upgrade eslint to v10 and mocha - #29
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Upgrades linting and test dependencies to support a secure js-yaml release and ESLint flat configuration.
Changes:
- Upgrades ESLint, its GitHub plugin, and Mocha.
- Migrates ESLint configuration to flat config.
- Overrides Mocha’s transitive
js-yamlversion.
Show a summary per file
| File | Description |
|---|---|
eslint.config.js |
Defines equivalent flat ESLint configuration and test globals. |
package.json |
Updates dependencies and adds the js-yaml override. |
package-lock.json |
Locks the updated dependency graph. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/3 changed files
- Comments generated: 0
- Review effort level: Medium
jibrang
reviewed
Jul 29, 2026
jibrang
approved these changes
Jul 29, 2026
jibrang
left a comment
jibrang
left a comment
Contributor
There was a problem hiding this comment.
Just a nit comment, otherwise LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://github.com/github/vuln-mgmt/issues/222630
This allows us to upgrade js-yaml. I had to upgrade eslint to v10, flat config, etc.
Note that Mocha’s mocha@12.0.0-rc.5 now declares js-yaml: ^5.0.0 but the current stable whose still declares ^4.1.0 which is why I added the override. Once v12 becomes stable, we won't need the override.