Repository navigation
Recover from rejected GitHub sessions instead of reporting no internet - #639
Open
brynrichards-gds wants to merge 1 commit into
Open
brynrichards-gds wants to merge 1 commit into
brynrichards-gds wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposed fix for the "Unable to connect to the GitHub API, please check your internet connection", as reported in issues like #582 .
Currently the canReachGitHubAPI call treats every error the same way, including a 401 that indicates bad credentials.
In my case the logs in ~/.vscode-server/data/logs/ showed the following:
Activating GitHub Actions extension...
Error getting GitHub context
HttpError: Bad credentials - https://docs.github.com/rest
Cannot fetch github context (repeated)
The changes in this PR check for an authentication failure, displays a message saying "Your GitHub session is no longer valid. [Sign in again]" and allows the sign in to update the github context.