Skip to content

chore(deps): npm audit fix — 29 → 7 advisories, vitest held on 4.0.x for Node 18 - #59

Merged
nTEG-dev merged 2 commits into
mainfrom
chore/npm-audit-fix
Sep 23, 2026
Merged

nTEG-dev merged 2 commits into
mainfrom
chore/npm-audit-fix

Conversation

@nTEG-dev

@nTEG-dev nTEG-dev commented Sep 23, 2026 •

Copy link
Copy Markdown
Member

npm audit fix: lockfile refresh, 29 advisories down to 7, Node 18 kept

Supersedes dependabot #19, closed because it conflicted with main and its hono target was still vulnerable.

  1. npm audit fix --legacy-peer-deps on the root, without --force.
  2. vitest is held at ~4.0.18 in package.json. The audit fix had moved it to 4.1.11, which pulls in vite 8 / rolldown. rolldown imports util.styleText, which Node 18 lacks, so the Node 18 CI job failed at vitest startup. gitmem still declares node >=18 and CI tests 18, so vitest stays on the 4.0 line. Dropping Node 18 is a separate decision.

Every other version moves only within its existing range. Examples: hono 4.12.0 → 4.13.8 (through @modelcontextprotocol/sdk), vite 7.3.1 → 7.3.6.

Customers are unaffected either way: npm never publishes the lockfile, and the only package.json change is a devDependency range.

Advisories

Before After
critical 2 1
high 17 1
moderate 8 5
low 2 0
total 29 7

Remaining, all accepted for now:

  • vitest (critical) and @vitest/mocker (moderate): fixed only in vitest ≥ 4.1.11, which needs Node ≥ 20. The critical one applies only while the Vitest UI server is running. Dev-only.
  • @testcontainers/postgresql → testcontainers → dockerode / undici (high): dev-only, used by the Docker-based e2e suites; needs a major upgrade.
  • uuid 9 → 14 (moderate): the advisory covers v3/v5/v6 with a buf argument. gitmem imports only v4, so it does not apply.

apps/docs/package-lock.json is deliberately untouched. Any change under apps/docs/ triggers the docs deploy workflow on merge.

Evidence (local, Node 22, after npm install from the new lockfile)

Check Result
typecheck, build clean
Unit 1437/1437
Smoke (free tier) 4/4
E2E: git-89, git-120, git-115 fresh install, cli-fresh-install 54/54
Hook suite, stock macOS PATH and slim PATH (scratch HOME) 54/54 each
Drift analyzer 14/14

There is no Node 18 locally, so CI's Node 18 build is the check for that. A full manual CI run with the venue gate covers this branch.

🤖 Generated with Claude Code

Claude and others added 2 commits September 22, 2026 22:58
`npm audit fix` (no --force) on the root lockfile. package.json is
unchanged; only resolved versions within existing ranges move, e.g. hono
4.12.0 -> 4.13.8 (via @modelcontextprotocol/sdk) and vitest 4.0.18 -> 4.1.11.
Supersedes dependabot #19 (closed).

Remaining 5 need a major bump: @testcontainers/postgresql chain (dev only,
incl. undici) and uuid 9 -> 14 (advisory is v3/v5/v6 with buf; gitmem uses
only v4). apps/docs is untouched: a change there triggers the docs deploy.

Customers are unaffected either way: npm never publishes the lockfile.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e 18

npm audit fix moved vitest to 4.1.11, which brings vite 8 / rolldown;
rolldown imports util.styleText, absent on Node 18, so the Node 18 CI job
failed at vitest startup. gitmem still declares node >=18 and CI tests 18,
so vitest stays on 4.0.18 (vite now 7.3.6, which clears vite's advisories).

Accepted for now: vitest's critical advisory (UI server file read/exec) and
@vitest/mocker's moderate one, both dev-only. Dropping Node 18 is a separate
decision.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@nTEG-dev nTEG-dev changed the title chore(deps): npm audit fix — lockfile refresh, 29 → 5 advisories chore(deps): npm audit fix — 29 → 7 advisories, vitest held on 4.0.x for Node 18 Sep 23, 2026
@nTEG-dev
nTEG-dev merged commit 2e3dee2 into main Sep 23, 2026
14 checks passed
@nTEG-dev
nTEG-dev deleted the chore/npm-audit-fix branch September 23, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant