Repository navigation
Conversation
…lish Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Member
Author
|
Closing without merging: Chris decided against a GitHub approval step. Releases go out when he tells the release agent to merge and tag. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
environment: npm-productionto thepublishjob in.github/workflows/ci.yml. Nothing else changes.Why
v1.11.2 published to npm within minutes of the tag push, with no human approval. The
publishjob onlyneedsbuild, the two hook jobs and the venue gate, then runsnpm publish; thenpm-productionapproval step that was expected did not exist anywhere in the workflow or in the repo's environments.With this change a
v*tag still runs build, hooks and the venue gate, then thepublishjob waits until a required reviewer approves thenpm-productionenvironment.Before this takes effect (Chris, in GitHub)
The environment has to exist with a required reviewer, otherwise GitHub creates it with no protection and publishes without waiting.
npm-production, Configure environment.v*, so only release tags can reach the environment.NPM_TOKENsecret from Settings → Secrets and variables → Actions → Repository secrets into this environment's secrets (same name), then delete the repository-level copy. A repository secret is readable by any workflow; an environment secret is released only after the approval.Test plan
v*tag: the run reachespublishand shows "Waiting for review"; nothing is on npm until Chris approves.Not merged. 🤖 Generated with Claude Code