rename(vnext): local-mcp source dir + glean_plugin server key - #9
Open
steve-calvert-glean wants to merge 1 commit into
Open
rename(vnext): local-mcp source dir + glean_plugin server key#9steve-calvert-glean wants to merge 1 commit into
steve-calvert-glean wants to merge 1 commit into
Conversation
sources/glean-vnext -> sources/local-mcp: the folder name described where the code came from (a folded-in "glean vnext" plugin), not what it is (the local stdio MCP server, its glean_run skill, and the auto-approve hook). Every sibling sources/* dir is named by host/purpose; this one wasn't. .mcp.json server key "glean-local" -> "glean_plugin": snake_case and glean-namespaced to match the convention used for client-side Glean MCP aliases (e.g. glean_default), distinct from the "plugin-mcp" name Glean's Admin console will use for the managed remote proxy server per the Dynamic Tools decision log (Decision 4) - those are two different namespaces and shouldn't collide. The auto-approve hook's legacy-key lookup now falls back through glean_plugin -> glean-local -> glean so a transitional install (only one of hook/.mcp.json updated yet) doesn't stop auto-approving. Updated every path/string reference across config, CI workflows, the CI shell-script guard, and docs/skill-reconciliation.md. CHANGELOG.md files are left untouched as historical release records.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two related naming cleanups to the local MCP server plumbing:
sources/glean-vnext→sources/local-mcp. The folder name described where the code came from (a folded-in "glean vnext" plugin, see feat: fold glean-vnext runtime MCP server into the glean plugin #3) rather than what it is: the local stdio MCP server, itsglean_runskill, and the auto-approve hook. Every siblingsources/*dir is named by host/purpose (claude,codex,cursor,shared,dev-docs); this one wasn't..mcp.jsonserver keyglean-local→glean_plugin. Snake_case andglean-namespaced, matching the convention used for client-side Glean MCP aliases (e.g.glean_default). This is a different namespace fromplugin-mcp, the name Glean's Admin console will use for the managed remote proxy server per the "Dynamic Tools: Decision Log" doc (Decision 4) — those two shouldn't collide, and dropping thegleanprefix locally would lose namespacing against other MCP servers a user might have configured.Details
pluginpack.config.ts,package.json, the CI shell-script guard (scripts/check-no-shell-scripts.mjs),.gitignore, both workflow files, anddocs/skill-reconciliation.md.glean_plugin→glean-local→glean, extending the fallback chain it already had (this isn't the first such rename) so a transitional install — only one of the hook or.mcp.jsonupdated so far — doesn't silently stop auto-approving.CHANGELOG.mdfiles (root + per-target) are left untouched; they're historical release records that reference specific past commit SHAs.Verification
npm run check:no-shell,npm run typecheck:bundle,npm run test:bundle(192 tests, including the renamed-key hook tests) all pass.npm test(full build + validate for claude/cursor/codex) passes; confirmed the generateddist/{claude,codex}/plugins/glean/.mcp.jsonship the newglean_pluginkey.grep -rn "glean-vnext"andgrep -rn '"glean-local"'confirm no stray references outside the intentional CHANGELOG history and hook fallback chain.🤖 Generated with Claude Code