Skip to content

pool: walk_special_pool abandons a region on one bad page header #86

Description

@glslang

From claude-review on #80. Regression introduced by #80.

Special pool is page-granular — each page is independent — but when decode_pool_header fails for one page, walk_special_pool breaks instead of continue-ing, abandoning every later page in the region.

Worse, unlike every other rejection path in the file it pushes no diagnostic and does not clear snapshot.complete. So snapshot_report reports complete: true after silently skipping most of a region — defeating the exact purpose that flag was added for in this same PR — and because SnapshotCache only caches complete snapshots, the truncated result is the one persisted and re-served.

Fix: continue rather than break, push a diagnostic naming the page, and clear complete, matching walk_lfh and walk_vs.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions