Repository navigation
Conversation
…rrives in A tax number had no vector at all in the identitycode suite and an identity card appeared only in a display case, so a code arriving under either was untested on the one path that decides who a person is. The suite now crosses all five recognised types with the separator, without it and in lower case, asserting the canonical value, Parse, Key and Display on each - a matrix rather than a row per type, because the separator handling and the type handling are independent and only crossing them catches a rule written for personal numbers alone. Removing IDC from the recognised set is caught by nothing else in the suite, which is how the gap was measured rather than assumed. No behaviour changed; a consumer needs no action. Signed-off-by: GatisB <l22exc@gmail.com>
A section's heading is what says what to tag; Unreleased says nothing a release decision can use. Patch, because the library's behaviour is unchanged and the only source touched is a test. Signed-off-by: GatisB <l22exc@gmail.com>
…anisation The identity types split into two lists, and a certificate carries them in two places: a natural person's code in the subject's serialNumber, a legal person's in its organizationIdentifier. Code.IsNaturalPerson answers that question, so a caller matching a code against a login no longer keeps its own list of which types are people. The set follows the standard rather than what this package currently parses -- every natural-person type it defines, so admitting a further type later cannot silently change the answer -- and it is false for anything the standard does not place with a person, an unrecognised type and a zero Code included, because the question is asked in order to refuse. A locally defined type appears in both lists and stays absent: whether it names a person is a national definition. Also here: SPECREFS.md, pinning the editions the bracketed citations resolve against, and a correction to the comment above the recognised set -- only the four natural types come from a serialNumber. Signed-off-by: GatisB <l22exc@gmail.com>
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.